-
Notifications
You must be signed in to change notification settings - Fork 35
DOCSP-43494-copilot-docs-command #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-mongodb-vscode ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ltran-mdb2 thanks for this update! This looks solid so far - just have some wording nits and suggestions for your consideration.
source/copilot-docs.txt
Outdated
:depth: 1 | ||
:class: singlecol | ||
|
||
The ``/docs`` command provides MongoDB specific information to users, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
I think "MongoDB specific" should be hyphenated:
The ``/docs`` command provides MongoDB specific information to users, | |
The ``/docs`` command provides MongoDB-specific information to users, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
source/copilot-docs.txt
Outdated
:depth: 1 | ||
:class: singlecol | ||
|
||
The ``/docs`` command provides MongoDB specific information to users, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Question]
Do we need to say "to users"? If we omit, this is more minimal and I think becomes slightly clearer that we're talking to the reader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitted!
source/copilot-docs.txt
Outdated
The ``/docs`` command provides MongoDB specific information to users, | ||
supplemented by links to MongoDB Documentation. The |copilot| is | ||
knowledgeable of the latest MongoDB Documentation and uses the | ||
MongoDB Docs Chatbot API to link users to information in addition to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nit]
Similar to my previous comment, the use of "users" here feels a little strange to me, since our docs are typically written in the second person. Maybe we can drop "users" here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
source/copilot-docs.txt
Outdated
the textual response. | ||
|
||
Example | ||
~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nit]
Since this is an h1 heading, let's use dash underlines -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
source/copilot-docs.txt
Outdated
supplemented by links to MongoDB Documentation. The |copilot| is | ||
knowledgeable of the latest MongoDB Documentation and uses the | ||
MongoDB Docs Chatbot API to link users to information in addition to | ||
the textual response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
the textual response. | |
the text response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
source/copilot-docs.txt
Outdated
Consider the following prompt that asks for information on creating an | ||
index in the GitHub Copilot chat: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nit, minimalism]
Consider the following prompt that asks for information on creating an | |
index in the GitHub Copilot chat: | |
The following prompt asks for information on creating an | |
index in the GitHub Copilot chat: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
source/copilot-docs.txt
Outdated
Consider the following prompt that asks for information on creating an | ||
index in the GitHub Copilot chat: | ||
|
||
.. code-block:: javascript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid the weird syntax highlighting in the code blocks, maybe try .. code-block:: none
here. Same comment applies to the response code-block further down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this suggestion! I also updated the /query page to use the none type to avoid the weird syntax highlighting
source/copilot-docs.txt
Outdated
.. figure:: /images/copilot-docs.png | ||
:figwidth: 700px | ||
:alt: Screenshot of copilot providing information on creating an index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need the screenshot here, if it's just showing what we've described above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check in with Garaub about this one - he originally asked for screenshots on the /query page to illustrate the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - happy to leave in if it's a PM request :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GaurabAryal do you have preference here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i think since this is such a new product, it is better to have the visuals in the docs. Let's keep it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % an optional small comment. Thanks @ltran-mdb2!
source/copilot-docs.txt
Outdated
- `Getting Started with MongoDB and Java - CRUD Operations Tutorial <https://www.mongodb.com/developer/languages/java/java-setup-crud-operations>`__ | ||
- `db.collection.createIndex() <https://mongodb.com/docs/manual/reference/method/db.collection.createIndex/>`__ | ||
|
||
The |copilot| also returns a textual response with information about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Minor]
To be consistent with the previous patch, let's maybe also edit to "text response" here.
The |copilot| also returns a textual response with information about | |
The |copilot| also returns a text response with information about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left two small suggestions, not blockers.
A heads up, we are going to structure the reference links a bit differently soon, moving them after the content and maybe also using the built in vscode references (which would show up above the content as a dropdown).
:ref:`/query <vsce-copilot-query>` | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
The ``/query`` command assists in generating queries from a natural |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit above this, in the paragraph before, we have written:
Through GitHub Copilot's chat feature, users with |vsce| can interact
with their MongoDB clusters and generate code with MongoDB
domain-specific knowledge on top of GitHub Copilot's LLM.
Should we add something about the MongoDB documentation chatbot there as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of simplicity, I would recommend only mentioning the documentation chatbot on the /docs page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did add a mention of learning about MongoDB in this section (referring to the /docs command)
source/copilot-docs.txt
Outdated
The ``/docs`` command provides MongoDB-specific information, | ||
supplemented by links to MongoDB Documentation. The |copilot| is | ||
knowledgeable of the latest MongoDB Documentation and uses the | ||
MongoDB Docs Chatbot API to link to information in addition to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MongoDB Docs Chatbot API to link to information in addition to | |
MongoDB Docs Chatbot to link to information in addition to |
I don't believe the API is intended for use outside of our use cases; we don't want folks using it at the moment. Maybe we can leave the API part out so folks don't get ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the mention of the API!
source/copilot-docs.txt
Outdated
:class: singlecol | ||
|
||
The ``/docs`` command provides MongoDB-specific information, | ||
supplemented by links to MongoDB Documentation. The |copilot| is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change the second sentence to something like:
For the docs command, the underlying model of the MongoDB Copilot Extension leverages Retrieval-Augmented Generation (RAG) to ensure responses are based on the latest version of MongoDB Documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
source/copilot-docs.txt
Outdated
MongoDB Docs Chatbot to link to information in addition to | ||
the text response. | ||
|
||
Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a second example here where the docs command recommends a DDP product like vector search or search in the context of "how do I improve the searching speed for query" and it responds with search/vector search recommendation? For vector search we might have to ask something like 'semantic search' in the prompt. This way users know that it can also be leveraged for performance-related questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a second example that recommends Atlas Vector Search!
source/copilot-docs.txt
Outdated
.. figure:: /images/copilot-docs.png | ||
:figwidth: 700px | ||
:alt: Screenshot of copilot providing information on creating an index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i think since this is such a new product, it is better to have the visuals in the docs. Let's keep it for now.
Through GitHub Copilot's chat feature, users with |vsce| can learn about | ||
MongoDB, interact with their MongoDB clusters, and generate code with | ||
MongoDB domain-specific knowledge on top of GitHub Copilot's LLM. The | ||
|copilot| can also answer questions about your database collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One general comment @ltran-mdb2 – could we switch the wording from MongoDB Github Copilot Participant to MongoDB Extension for Github Copilot? I just confirmed with the team at VS Code that participant isn't the proper branding (more of an implementation detail) and they want us to go with "MongoDB Extension" instead. Sorry for the change in wording!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Thanks for your feedback @GaurabAryal ! Could you take another look when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, thanks for all the updates Lauren! 🌟
DESCRIPTION
Adding page on /docs command with the VSCode Copilot Participant
STAGING
https://deploy-preview-96--docs-mongodb-vscode.netlify.app/copilot/
https://deploy-preview-96--docs-mongodb-vscode.netlify.app/copilot-docs/
JIRA
https://jira.mongodb.org/browse/DOCSP-43494
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?